lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20071126202836.GA17012@elte.hu>
Date:	Mon, 26 Nov 2007 21:28:36 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Srivatsa Vaddagiri <vatsa@...ux.vnet.ibm.com>
Cc:	dmitry.adamushko@...il.com, a.p.zijlstra@...llo.nl,
	dhaval@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org,
	efault@....de, skumar@...ux.vnet.ibm.com,
	Balbir Singh <balbir@...ibm.com>,
	Dipankar <dipankar@...ibm.com>
Subject: Re: [Patch 4/4] sched: Improve fairness of cpu bandwidth
	allocation for task groups


* Srivatsa Vaddagiri <vatsa@...ux.vnet.ibm.com> wrote:

> +	/* we don't want this thread's execution to be limited by the shares
> +	 * assigned to default group (init_task_group). Hence make it run
> +	 * as a RT task.
> +	 */
> +	schedparm.sched_priority = 0; /* run at the lowest RT prio */
> +	ret = sched_setscheduler(current, SCHED_RR, &schedparm);
> +	if (ret)
> +		printk(KERN_ERR "Couldn't set SCHED_RR policy for load balance"
> +				"monitor thread (error = %d) \n", ret);

the first SCHED_RR priority is 1, not 0 - so this call will always fail.

> +		lock_cpu_hotplug(); /* Prevent cpus going down or coming up */
> +		lock_doms_cur();    /* lockout changes to doms_cur[] array */

please put comments in front of the line like we do in most of sched.c.

> +		rcu_read_lock();  /* to walk rq->sd chain on various cpus and to
> +				   * walk task group list in rebalance_shares().
> +				   */

the proper comment format is in front of the line and in:

	/*
	 * Comment.
	 */

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ