linux-kernel - Re: [Patch 4/4] sched: Improve fairness of cpu bandwidth allocation for task groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071126202939.GB17012@elte.hu>
Date:	Mon, 26 Nov 2007 21:29:39 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Srivatsa Vaddagiri <vatsa@...ux.vnet.ibm.com>
Cc:	dmitry.adamushko@...il.com, a.p.zijlstra@...llo.nl,
	dhaval@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org,
	efault@....de, skumar@...ux.vnet.ibm.com,
	Balbir Singh <balbir@...ibm.com>,
	Dipankar <dipankar@...ibm.com>
Subject: Re: [Patch 4/4] sched: Improve fairness of cpu bandwidth
	allocation for task groups


* Srivatsa Vaddagiri <vatsa@...ux.vnet.ibm.com> wrote:

> +static inline void lock_doms_cur(void)
> +{
> +	mutex_lock(&doms_cur_mutex);
> +}
> +
> +static inline void unlock_doms_cur(void)
> +{
> +	mutex_unlock(&doms_cur_mutex);
> +}
> +
>  #else
>  
>  static inline void set_task_cfs_rq(struct task_struct *p, unsigned int cpu) { }
>  static inline void lock_task_group_list(void) { }
>  static inline void unlock_task_group_list(void) { }
> +static inline void lock_doms_cur(void) { }
> +static inline void unlock_doms_cur(void) { }
>  
>  #endif	/* CONFIG_FAIR_GROUP_SCHED */
>  
> @@ -6546,6 +6605,8 @@
>  {
>  	int i, j;
>  
> +	lock_doms_cur();
> +
>  	/* always unregister in case we don't destroy any domains */
>  	unregister_sched_domain_sysctl();
>  
> @@ -6586,6 +6647,8 @@
>  	ndoms_cur = ndoms_new;
>  
>  	register_sched_domain_sysctl();
> +
> +	unlock_doms_cur();
>  }

this API and locking should be introduced in a separate patch first, to 
reduce the size and impact of the 4/4 patch.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/