linux-kernel - Re: [PATCH][SHMEM] Factor out sbi->free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0711270835170.19731@blonde.wat.veritas.com>
Date:	Tue, 27 Nov 2007 08:36:41 +0000 (GMT)
From:	Hugh Dickins <hugh@...itas.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
cc:	Pavel Emelyanov <xemul@...nvz.org>, Linux MM <linux-mm@...ck.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	devel@...nvz.org
Subject: Re: [PATCH][SHMEM] Factor out sbi->free_inodes manipulations

On Mon, 26 Nov 2007, Andrew Morton wrote:
> 
> It is peculair to (wrongly) return -ENOMEM
> 
> > +	if (shmem_reserve_inode(inode->i_sb))
> > +		return -ENOSPC;
> 
> and to then correct it in the caller..

Oops, I missed that completely.

> Something boringly conventional such as the below, perhaps?

Much better, thanks.

Hugh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/