[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20071127010254.133e222f.akpm@linux-foundation.org>
Date: Tue, 27 Nov 2007 01:02:54 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Davide Libenzi <davidel@...ilserver.org>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Michael Kerrisk <mtk-manpages@....net>,
Thomas Gleixner <tglx@...utronix.de>,
Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [patch 2/4] Timerfd v3 - new timerfd API
On Sun, 25 Nov 2007 14:14:19 -0800 Davide Libenzi <davidel@...ilserver.org> wrote:
> +static struct file *timerfd_fget(int fd)
> +{
> + struct file *file;
> +
> + file = fget(fd);
> + if (!file)
> + return ERR_PTR(-EBADF);
> + if (file->f_op != &timerfd_fops) {
> + fput(file);
> + return ERR_PTR(-EINVAL);
> + }
> +
> + return file;
> +}
I suppose we could use fget_light() in here sometime. It is significantly
quicker in microbenchmarks. Or it was - nobody has checked that in a few
years afaik.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists