lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20071127090101.GA2626@hacking>
Date:	Tue, 27 Nov 2007 17:01:01 +0800
From:	WANG Cong <xiyou.wangcong@...il.com>
To:	Richard Knutsson <ricknu-0@...dent.ltu.se>
Cc:	mchehab@...radead.org, v4l-dvb-maintainer@...uxtv.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [VIDEO]: Complement va_start() with va_end().

On Tue, Nov 27, 2007 at 08:06:17AM +0100, Richard Knutsson wrote:
>Complement va_start() with va_end().
>
>Signed-off-by: Richard Knutsson <ricknu-0@...dent.ltu.se>
>---
>Compile-tested on i386 with allyesconfig and allmodconfig.
>
>
>diff --git a/drivers/media/video/saa5246a.c b/drivers/media/video/saa5246a.c
>index ad02329..996b494 100644
>--- a/drivers/media/video/saa5246a.c
>+++ b/drivers/media/video/saa5246a.c
>@@ -187,12 +187,14 @@ static int i2c_senddata(struct saa5246a_device *t, ...)
> {
> 	unsigned char buf[64];
> 	int v;
>-	int ct=0;
>+	int ct = 0;
> 	va_list argp;
>-	va_start(argp,t);
>+	va_start(argp, t);

Hi, Richard!

These are style fixes, and you did't mention this above. ;)

Thanks.


 Cong

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ