linux-kernel - Re: [patch] Fix hpet wrong values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071128103851.GA19701@elte.hu>
Date:	Wed, 28 Nov 2007 11:38:51 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Pavel Machek <pavel@....cz>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	kernel list <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [patch] Fix hpet wrong values


* Pavel Machek <pavel@....cz> wrote:

> If hpet is not enabled in config, its init should not pretend to work, 
> and people should not try to get time from it.
> 
> Signed-off-by: Pavel Machek <pavel@...e.cz>

a crasher bug sneaked into x86.git (see the crash log further below) and 
git-bisect tracked it down to your patch:

 ---------------->
 e09e9089131ca0227a716aee143f49d084977e32 is first bad commit
 commit e09e9089131ca0227a716aee143f49d084977e32
 Author: Pavel Machek <pavel@....cz>
 Date:   Wed Nov 28 03:06:03 2007 +0100

      x86: fix wrong hpet values
 <----------------

Config attached.

	Ingo

---------------
[   13.067986] Checking if this processor honours the WP bit even in supervisor mode... Ok.
[   13.091744] BUG: unable to handle kernel NULL pointer dereference at virtual address 0000002c
[   13.100103] printing eip: c0105c55 *pdpt = 0000000000a51001 *pde = 0000000000000000 
[   13.107817] Oops: 0000 [#1] PREEMPT 
[   13.111369] 
[   13.112844] Pid: 0, comm: swapper Not tainted (2.6.24-rc3-ge09e9089-dirty #8)
[   13.119949] EIP: 0060:[<c0105c55>] EFLAGS: 00010046 CPU: 0
[   13.125413] EIP is at timer_interrupt+0x35/0x60
[   13.129915] EAX: 00000000 EBX: c08f1f48 ECX: c0c19558 EDX: 00000000
[   13.136155] ESI: 00000000 EDI: 00000000 EBP: c09f9f00 ESP: c09f9efc
[   13.142395]  DS: 007b ES: 007b FS: 0000 GS: 0000 SS: 0068
[   13.147768] Process swapper (pid: 0, ti=c09f8000 task=c08ea3f0 task.ti=c09f8000)
[   13.154960] Stack: c08f1f48 c09f9f18 c0144dba 00000000 c08f7330 00000000 c08f1f48 c09f9f30 
[   13.163279]        c014616e c08f7360 00000000 c08f7330 00000000 c09f9f48 c01053d3 00000000 
[   13.171599]        ffff8ad1 00099800 c09f9fd4 c09f9f88 c0103bf3 ffff8ad1 00000000 00000006 
[   13.179918] Call Trace:
[   13.182518]  [<c0104192>] show_trace_log_lvl+0x12/0x30
[   13.187632]  [<c010423a>] show_stack_log_lvl+0x8a/0xa0
[   13.192744]  [<c01042d2>] show_registers+0x82/0x190
[   13.197597]  [<c01044db>] die+0xfb/0x1d0
[   13.201497]  [<c0111a86>] do_page_fault+0x696/0x780
[   13.206350]  [<c06d3be2>] error_code+0x6a/0x70
[   13.210769]  [<c0144dba>] handle_IRQ_event+0x1a/0x50
[   13.215709]  [<c014616e>] handle_level_irq+0xae/0xc0
[   13.220649]  [<c01053d3>] do_IRQ+0x53/0x70
[   13.224721]  [<c0103bf3>] common_interrupt+0x23/0x28
[   13.229662]  [<c02ed860>] read_current_timer+0x20/0x40
[   13.234774]  [<c01005de>] calibrate_delay+0x9e/0x270
[   13.239714]  [<c09faa3e>] start_kernel+0x21e/0x290
[   13.244481]  [<00000000>] 0x0
[   13.247427]  =======================
[   13.250980] INFO: lockdep is turned off.
[   13.254880] Code: a5 c0 00 55 89 e5 53 74 1a b8 90 e5 8e c0 e8 c3 d7 5c 00 b0 0c e6 20 e4 20 b8 90 e5 8e c0 e8 c3 db 5c 00 8b 15 04 32 a5 c0 89 d0 <ff> 52 2c 83 3d f8 32 a5 c0 00 74 17 e4 61 88 c3 83 cb 80 ff 15 
[   13.273686] EIP: [<c0105c55>] timer_interrupt+0x35/0x60 SS:ESP 0068:c09f9efc
[   13.280705] Kernel panic - not syncing: Fatal exception in interrupt


View attachment "config.bad" of type "text/plain" (45025 bytes)