linux-kernel - Re: [patch] Fix hpet wrong values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071128104040.GA20113@elte.hu>
Date:	Wed, 28 Nov 2007 11:40:40 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Pavel Machek <pavel@....cz>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	kernel list <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [patch] Fix hpet wrong values


* Ingo Molnar <mingo@...e.hu> wrote:

>  ---------------->
>  e09e9089131ca0227a716aee143f49d084977e32 is first bad commit
>  commit e09e9089131ca0227a716aee143f49d084977e32
>  Author: Pavel Machek <pavel@....cz>
>  Date:   Wed Nov 28 03:06:03 2007 +0100
> 
>       x86: fix wrong hpet values
>  <----------------

it's the hpet_enable() returning non-0 that is causing the crash. The 
current patch that is in x86.git is below.

	Ingo

------------------->
Subject: x86: fix wrong hpet values
From: Pavel Machek <pavel@....cz>

If hpet is not enabled in config, its init should not pretend to work,
and people should not try to get time from it.

Signed-off-by: Pavel Machek <pavel@...e.cz>
Signed-off-by: Ingo Molnar <mingo@...e.hu>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
---
 include/asm-x86/hpet.h |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Index: linux-x86.q/include/asm-x86/hpet.h
===================================================================
--- linux-x86.q.orig/include/asm-x86/hpet.h
+++ linux-x86.q/include/asm-x86/hpet.h
@@ -82,8 +82,7 @@ extern irqreturn_t hpet_rtc_interrupt(in
 
 #else
 
-static inline int hpet_enable(void) { return 0; }
-static inline unsigned long hpet_readl(unsigned long a) { return 0; }
+static inline int hpet_enable(void) { return -ENODEV; }
 
 #endif /* CONFIG_HPET_TIMER */
 #endif /* ASM_X86_HPET_H */
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/