linux-kernel - Re: [linux-usb-devel] [BUG] USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0711291406460.5666-100000@iolanthe.rowland.org>
Date:	Thu, 29 Nov 2007 14:07:41 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Mark Lord <lkml@....ca>
cc:	Raymano Garibaldi <raymano@...nos.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Denys Vlasenko <vda.linux@...glemail.com>,
	Kernel development list <linux-kernel@...r.kernel.org>,
	USB development list <linux-usb-devel@...ts.sourceforge.net>,
	<kirk@...nos.com>
Subject: Re: [linux-usb-devel] [BUG] USB_PERSIST

On Thu, 29 Nov 2007, Mark Lord wrote:

> Alan Stern wrote:
> > On Thu, 29 Nov 2007, Raymano Garibaldi wrote:
> > 
> >> The feature does work as long as the device remains plugged in and
> >> that is what I have said in my previous postings too. What I'm saying
> >> that should work and worked under 2.6.21 and is not working currently
> >> is the ability to unplug and plug back in the device while the
> >> computer is suspended before resuming without losing the mount.
> > 
> > Okay, guess I misunderstood what you wrote before.
> > 
> > The patch below for 2.6.23 should do what you want (and more besides).  
> > It forces the USB Persist feature to apply to all persist-enabled 
> > devices, whether they were unplugged or not.
> > 
> > There's no chance of this getting accepted into the official kernel in 
> > such a simple form, but at least it will allow you to do what you want.
> > 
> > Alan Stern
> > 
> > 
> > --- 2.6.23/drivers/usb/core/driver.c1	2007-11-29 10:57:36.000000000 -0500
> > +++ 2.6.23/drivers/usb/core/driver.c	2007-11-29 11:01:44.000000000 -0500
> > @@ -1550,6 +1550,9 @@
> >  		if (!(udev->reset_resume && udev->do_remote_wakeup))
> >  			return -EPERM;
> >  	}
> > +
> > +	/* Force all system resumes to be reset-resumes */
> > +	udev->reset_resume = 1;
> >  	return usb_external_resume_device(udev);
> >  }
> ..
> 
> Mmm.. how about a nice sysfs attr that the suspend scripts can write
> that value to as needed ?

Write what value to?  Besides, there already _is_ a sysfs attribute
scripts can use to enable or disable USB-Persist for each device.

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/