linux-kernel - Re: [linux-usb-devel] [BUG] USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1618816c0711292037w34bd383av6cf32bfbd8d45707@mail.gmail.com>
Date:	Thu, 29 Nov 2007 21:37:28 -0700
From:	"Raymano Garibaldi" <raymano@...nos.com>
To:	"Alan Stern" <stern@...land.harvard.edu>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Denys Vlasenko" <vda.linux@...glemail.com>,
	"Kernel development list" <linux-kernel@...r.kernel.org>,
	"USB development list" <linux-usb-devel@...ts.sourceforge.net>,
	kirk@...nos.com
Subject: Re: [linux-usb-devel] [BUG] USB_PERSIST

On 11/29/07, Alan Stern <stern@...land.harvard.edu> wrote:
> On Thu, 29 Nov 2007, Raymano Garibaldi wrote:
>
> > The feature does work as long as the device remains plugged in and
> > that is what I have said in my previous postings too. What I'm saying
> > that should work and worked under 2.6.21 and is not working currently
> > is the ability to unplug and plug back in the device while the
> > computer is suspended before resuming without losing the mount.
>
> Okay, guess I misunderstood what you wrote before.
>
> The patch below for 2.6.23 should do what you want (and more besides).
> It forces the USB Persist feature to apply to all persist-enabled
> devices, whether they were unplugged or not.
>
> There's no chance of this getting accepted into the official kernel in
> such a simple form, but at least it will allow you to do what you want.
>
> Alan Stern
>
>
> --- 2.6.23/drivers/usb/core/driver.c1   2007-11-29 10:57:36.000000000 -0500
> +++ 2.6.23/drivers/usb/core/driver.c    2007-11-29 11:01:44.000000000 -0500
> @@ -1550,6 +1550,9 @@
>                 if (!(udev->reset_resume && udev->do_remote_wakeup))
>                         return -EPERM;
>         }
> +
> +       /* Force all system resumes to be reset-resumes */
> +       udev->reset_resume = 1;
>         return usb_external_resume_device(udev);
>  }
>
>
>

Alan,

Thank you! Thank you! Thank you!

Who'd have thought such a simple patch could make someone so happy?

That did the trick. I just tried it and it works beautifully whether
the device remains plugged in during suspend or if it's unplugged and
plugged back in during suspend and before resume.

Now if this could only become the default behavior ;-)

Thanks again,
Raymano G.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/