linux-kernel - Re: [PATCH 1/7] Blackfin RTC driver: the frequency function is in units of Hz, not units of seconds, so lock our driver down to 1 Hz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 4 Dec 2007 17:26:34 +0100
From:	Alessandro Zummo <alessandro.zummo@...ertech.it>
To:	Bryan Wu <bryan.wu@...log.com>
Cc:	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org,
	uclinux-dist-devel@...ckfin.uclinux.org,
	Mike Frysinger <michael.frysinger@...log.com>,
	Bryan Wu <bryan.wu@...log.com>
Subject: Re: [PATCH 1/7] Blackfin RTC driver: the frequency function is in
 units of Hz, not units of seconds, so lock our driver down to 1 Hz

On Fri, 23 Nov 2007 18:08:26 +0800
Bryan Wu <bryan.wu@...log.com> wrote:

 Hi, I fannly got some time to review the patches. Seems ok, the
 only question is...

> static int bfin_irq_set_freq(struct device *dev, int freq)
>  {
> -	struct bfin_rtc *rtc = dev_get_drvdata(dev);
>  	stampit();
> -	rtc->rtc_dev->irq_freq = freq;
> -	return 0;
> +	return -ENOTTY;
>  }

 .. why ENOTTY here?

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/