[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8bd0f97a0712040829i116496deu384453c6eccfa252@mail.gmail.com>
Date: Tue, 4 Dec 2007 11:29:11 -0500
From: "Mike Frysinger" <vapier.adi@...il.com>
To: rtc-linux@...glegroups.com
Cc: "Bryan Wu" <bryan.wu@...log.com>, linux-kernel@...r.kernel.org,
uclinux-dist-devel@...ckfin.uclinux.org,
"Mike Frysinger" <michael.frysinger@...log.com>
Subject: Re: [rtc-linux] Re: [PATCH 1/7] Blackfin RTC driver: the frequency function is in units of Hz, not units of seconds, so lock our driver down to 1 Hz
On Dec 4, 2007 11:26 AM, Alessandro Zummo <alessandro.zummo@...ertech.it> wrote:
> Bryan Wu <bryan.wu@...log.com> wrote:
>
> Hi, I fannly got some time to review the patches. Seems ok, the
> only question is...
>
> > static int bfin_irq_set_freq(struct device *dev, int freq)
> > {
> > - struct bfin_rtc *rtc = dev_get_drvdata(dev);
> > stampit();
> > - rtc->rtc_dev->irq_freq = freq;
> > - return 0;
> > + return -ENOTTY;
> > }
>
> .. why ENOTTY here?
blah, hit "reply" in previous e-mail ...
that's what the documentation says to do as does every other rtc driver ?
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists