lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 5 Dec 2007 15:51:37 +0100
From:	Ingo Molnar <>
To:	Joerg Roedel <>
Subject: Re: [PATCH] x86_64: some whitespace cleanups in paging code

* Joerg Roedel <> wrote:

> This patch does some whitespace cleanups in the paging code to fix 
> some warnings of my formerly merged cleanup patches.

thanks, applied.

btw., if there's any file you are particularly interested in cleaning up 
as a whole, you can use the --file option:

  scripts/ --file include/asm-x86/pgtable_64.h

there's no hard policy on whether cleanups should be done 
pre-unification or post-unification. I've been using the following 
pretty sensible 3-step path when doing manual unifications:

- clean up the _32 and _64 file first (this is also easy to check - the 
  resulting .o or vmlinux must not differ with/without the patch)

- remove artificial differences (in a separate patch)

- do the unification (in a third patch)

the general rule, more patches are better than fewer patches. Most of 
our testing/bisetion infrastructure is per-patch/per-commit, so if some 
mistake happens (and mistakes happen all the time), the finer grained 
approach is always easier to sort out.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists