linux-kernel - Re: [PATCH] x86_64: some whitespace cleanups in paging code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071205163724.GA1024@osiris.boeblingen.de.ibm.com>
Date:	Wed, 5 Dec 2007 17:37:24 +0100
From:	Heiko Carstens <heiko.carstens@...ibm.com>
To:	Joerg Roedel <joerg.roedel@....com>
Cc:	mingo@...e.hu, tglx@...utronix.de, hpa@...or.com,
	linux-kernel@...r.kernel.org, Andy Whitcroft <apw@...dowen.org>
Subject: Re: [PATCH] x86_64: some whitespace cleanups in paging code

On Wed, Dec 05, 2007 at 03:40:12PM +0100, Joerg Roedel wrote:
> This patch does some whitespace cleanups in the paging code to fix some
> checkpatch.pl warnings of my formerly merged cleanup patches.
>...
> -			set_pmd(pmd + i,__pmd(addr | __PAGE_KERNEL_LARGE_EXEC));
> +			set_pmd(pmd+i, __pmd(addr | __PAGE_KERNEL_LARGE_EXEC));

Did checkpatch enforce you to remove the spaces around '+'? I thought
there was/is a common consensus that having spaces around operators is a good
thing to have. IMHO it's much more readable...
But anyway, it's not that I want to start a new thread about coding style :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/