linux-kernel - Re: [PATCH] x86_64: some whitespace cleanups in paging code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071205172453.GF23093@amd.com>
Date:	Wed, 5 Dec 2007 18:24:53 +0100
From:	"Joerg Roedel" <joerg.roedel@....com>
To:	"Heiko Carstens" <heiko.carstens@...ibm.com>
cc:	mingo@...e.hu, tglx@...utronix.de, hpa@...or.com,
	linux-kernel@...r.kernel.org, "Andy Whitcroft" <apw@...dowen.org>
Subject: Re: [PATCH] x86_64: some whitespace cleanups in paging code

On Wed, Dec 05, 2007 at 05:37:24PM +0100, Heiko Carstens wrote:
> On Wed, Dec 05, 2007 at 03:40:12PM +0100, Joerg Roedel wrote:
> > This patch does some whitespace cleanups in the paging code to fix some
> > checkpatch.pl warnings of my formerly merged cleanup patches.
> >...
> > -			set_pmd(pmd + i,__pmd(addr | __PAGE_KERNEL_LARGE_EXEC));
> > +			set_pmd(pmd+i, __pmd(addr | __PAGE_KERNEL_LARGE_EXEC));
> 
> Did checkpatch enforce you to remove the spaces around '+'? I thought
> there was/is a common consensus that having spaces around operators is a good
> thing to have. IMHO it's much more readable...
> But anyway, it's not that I want to start a new thread about coding style :)

Checkpatch complained about a missing space after the comma. After I
added one it complained about a line longer than 80 characters. But
luckily it didn't complain about missing spaces around the plus sign ;)

-- 
           |           AMD Saxony Limited Liability Company & Co. KG
 Operating |         Wilschdorfer Landstr. 101, 01109 Dresden, Germany
 System    |                  Register Court Dresden: HRA 4896
 Research  |              General Partner authorized to represent:
 Center    |             AMD Saxony LLC (Wilmington, Delaware, US)
           | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/