linux-kernel - Re: [PATCH] USB: option: Bind to the correct interface of the Huawei E220

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071205083423.ca6ef199.zaitcev@redhat.com>
Date:	Wed, 5 Dec 2007 08:34:23 -0800
From:	Pete Zaitcev <zaitcev@...hat.com>
To:	Jaime Velasco Juan <jsagarribay@...il.com>
Cc:	Oliver Neukum <oliver@...kum.org>,
	Johann Wilhelm <johann.wilhelm@...dent.tugraz.at>,
	Rui Santos <rsantos@...popie.com>, linux-usb@...r.kernel.org,
	preining@...ic.at, kristoffer.ericson@...il.com,
	drussell@...hat.com, linux-kernel@...r.kernel.org, greg@...ah.com,
	zaitcev@...hat.com
Subject: Re: [PATCH] USB: option: Bind to the correct interface of the
 Huawei E220

On Fri, 30 Nov 2007 16:30:11 +0000, Jaime Velasco Juan <jsagarribay@...il.com> wrote:

> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> -	{ USB_DEVICE(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E220) },
> -	{ USB_DEVICE(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E220BIS) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E220, 0xff, 0xff, 0xff) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E220BIS, 0xff, 0xff, 0xff) },

Looks good to me, shorter than my patch, has no duplication, allows to
use the storage, looks like a winner. Unfortunately, it leaves ub for dead,
because ub cannot invoke the necessary initializer unless we move it to
libusual. But oh well, I'll think about it.

Took me this long to test because I had to ask kind people in England
to replug the modem.

Signed-off-by: Pete Zaitcev <zaitcev@...hat.com>

-- Pete
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/