lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 5 Dec 2007 16:36:07 +1100 From: Herbert Xu <herbert@...dor.apana.org.au> To: Joonwoo Park <joonwpark81@...il.com> Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 'David Miller' <davem@...emloft.net> Subject: Re: [PATCH] NET: ASSERT_RTNL in __dev_set_promiscuity makes debug warning On Wed, Dec 05, 2007 at 02:30:10PM +0900, Joonwoo Park wrote: > > @@ -140,9 +147,11 @@ int dev_mc_sync(struct net_device *to, struct net_device *from) > da = next; > } > if (!err) > - __dev_set_rx_mode(to); > + pending = __dev_set_rx_mode(to); > netif_tx_unlock_bh(to); > > + if (pending) > + __dev_set_rx_mode_fini(to); The idea is to not touch the unicast stuff at all on the multicast path. Anyway, this was discussed on netdev so please check the archives because there is more to this than just changing the multicast handling. We also talked about consolidating the driver interface so that all these calls have the same environment rather than the mix-and-match that we have now. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists