lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 7 Dec 2007 04:40:52 +1100 From: Herbert Xu <herbert@...dor.apana.org.au> To: Richard Knutsson <ricknu-0@...dent.ltu.se> Cc: David Miller <davem@...emloft.net>, xiyou.wangcong@...il.com, linux-kernel@...r.kernel.org, akpm@...l.org, netdev@...r.kernel.org Subject: Re: [Patch] net/xfrm/xfrm_policy.c: Some small improvements On Thu, Dec 06, 2007 at 03:37:46PM +0100, Richard Knutsson wrote: > > Is it not an improvement to distinct booleans from actual values? Do you > use integers for ASCII characters too? It can also avoid some potential > bugs like the 'if (i == TRUE)'... > What is wrong with 'size_t' (since it is unsigned, compared to (some) > 'int')? I agree with Dave. There are so many useful things that we can do (and need to do) in IPsec that bool/size_t conversions just add churn without adding much value. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists