lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 06 Dec 2007 15:37:46 +0100 From: Richard Knutsson <ricknu-0@...dent.ltu.se> To: David Miller <davem@...emloft.net> CC: xiyou.wangcong@...il.com, linux-kernel@...r.kernel.org, herbert@...dor.apana.org.au, akpm@...l.org, netdev@...r.kernel.org Subject: Re: [Patch] net/xfrm/xfrm_policy.c: Some small improvements David Miller wrote: > From: WANG Cong <xiyou.wangcong@...il.com> > Date: Thu, 6 Dec 2007 19:01:23 +0800 > > >> This patch contains the following changes. >> >> - Use 'bool' instead of 'int' for booleans. >> - Use 'size_t' instead of 'int' for 'sizeof' return value. >> - Some style fixes. >> >> Cc: Herbert Xu <herbert@...dor.apana.org.au> >> Cc: David Miller <davem@...emloft.net> >> Signed-off-by: WANG Cong <xiyou.wangcong@...il.com> >> > > Normally I would let a patch like this sit in my mailbox > for a week and then delete it. > That is evil! ;) > But this time I'll just let you know up front that I > don't see much value in this patch. It is not a clear > improvement to replace int's with bool's in my mind and > the other changes are just whitespace changes. > Is it not an improvement to distinct booleans from actual values? Do you use integers for ASCII characters too? It can also avoid some potential bugs like the 'if (i == TRUE)'... What is wrong with 'size_t' (since it is unsigned, compared to (some) 'int')? /Richard Knutsson -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists