lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 6 Dec 2007 21:45:02 +0300 From: Oleg Nesterov <oleg@...sign.ru> To: "Eric W. Biederman" <ebiederm@...ssion.com> Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org, Linux Containers <containers@...ts.osdl.org>, Pavel Emelyanov <xemul@...nvz.org>, sukadev@...ibm.com Subject: Re: [PATCH] pid: sys_wait... fixes (v2) On 12/06, Eric W. Biederman wrote: > > +static struct pid *task_pid_type(struct task_struct *task, enum pid_type type) > +{ > + struct pid *pid = NULL; > + if (type == PIDTYPE_PID) > + pid = task->pids[type].pid; > + else if (type < PIDTYPE_MAX) > + pid = task->group_leader->pids[type].pid; > + return pid; > +} Looks like a useful helper regardless. > +static int eligible_child(enum pid_type type, struct pid *pid, int options, > + struct task_struct *p) > { > int err; > - struct pid_namespace *ns; > > - ns = current->nsproxy->pid_ns; > - if (pid > 0) { > - if (task_pid_nr_ns(p, ns) != pid) > - return 0; > - } else if (!pid) { > - if (task_pgrp_nr_ns(p, ns) != task_pgrp_vnr(current)) > - return 0; > - } else if (pid != -1) { > - if (task_pgrp_nr_ns(p, ns) != -pid) > + if (type < PIDTYPE_MAX) { > + if (task_pid_type(p, type) != pid) > return 0; > } Minor, minor nit. If type == PIDTYPE_MAX, pid must be == NULL. but task_pid_type(PIDTYPE_PID) also returns NULL. So we can just do if (task_pid_type(p, type) != pid) return 0; Not that it really makes a difference though. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists