linux-kernel - Re: [PATCH] ipwireless_cs driver for 4G PC Card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 7 Dec 2007 01:28:28 +0100
From:	Marcel Holtmann <marcel@...tmann.org>
To:	David Sterba <dsterba@...e.cz>
Cc:	"Robert P. J. Day" <rpjday@...shcourse.ca>,
	linux-kernel@...r.kernel.org, linux-pcmcia@...ts.infradead.org,
	akpm@...ux-foundation.org, jeff@...zik.org, jkosina@...e.cz,
	jslaby@...e.cz, stephen@...metric.co.nz, benm@...metric.co.nz
Subject: Re: [PATCH] ipwireless_cs driver for 4G PC Card

Hi David,

>> might it not make more sense to put all of that into a new
>> subdirectory, say, /drivers/char/pcmcia/ipwireless_cs?  that way,  
>> it's
>> more modular and it will keep that higher-level directory from
>> potentially getting cluttered with even more drivers.  and it would
>> let you drop the pointless "ipwireless_cs_" prefix from all of those
>> files as well.
>
> ok, will put it into ipwireless, and the _cs suffix will go away as  
> suggested
> elsewhere. The filenames will then get very generic names, do you have
> suggestion for better names? There are many drivers in own directory  
> and
> files inside have the same prefix. Maybe we can use names like ipw- 
> hw.c, etc.

don't use "ipw" as prefix. It is too close to the Intel wireless  
drivers and will only create confusion. The generic filenames in a  
subdirectory don't matter. The module name is what counts.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/