lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 7 Dec 2007 15:07:09 +1100 From: Nick Piggin <nickpiggin@...oo.com.au> To: Li Zefan <lizf@...fujitsu.com> Cc: paulus@...ba.org, LKML <linux-kernel@...r.kernel.org>, linuxppc-dev@...abs.org, Andrew Morton <akpm@...ux-foundation.org> Subject: Re: [PATCH 1/3] POWERPC: don't cast a pointer to pointer of list_head On Thursday 06 December 2007 20:33, Li Zefan wrote: > The casting is safe only when the list_head member is the > first member of the structure. Even so, I don't think too safe :) It might technically work, but it could break more easily. So even if you find places where list_head is the first member of a structure, it would be nice to explicitly use the list_head member and avoid casts IMO. Thanks, Nick > Signed-off-by: Li Zefan <lizf@...fujitsu.com> > > --- > arch/ppc/syslib/ocp.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/ppc/syslib/ocp.c b/arch/ppc/syslib/ocp.c > index 3f5be2c..d42d408 100644 > --- a/arch/ppc/syslib/ocp.c > +++ b/arch/ppc/syslib/ocp.c > @@ -376,7 +376,7 @@ ocp_remove_one_device(unsigned int vendor, unsigned int > function, int index) > > down_write(&ocp_devices_sem); > dev = __ocp_find_device(vendor, function, index); > - list_del((struct list_head *)dev); > + list_del(&dev->link); > up_write(&ocp_devices_sem); > > DBG(("ocp: ocp_remove_one_device(vendor: %x, function: %x, index: %d)... > done.\n", vendor, function, index)); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists