linux-kernel - [PATCH] mmc: remove unused 'mode' from the mmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-id: <alpine.LFD.0.99999.0712062257310.555@xanadu.home>
Date:	Thu, 06 Dec 2007 23:12:46 -0500 (EST)
From:	Nicolas Pitre <nico@....org>
To:	Pierre Ossman <drzeus@...eus.cx>
Cc:	lkml <linux-kernel@...r.kernel.org>
Subject: [PATCH] mmc: remove unused 'mode' from the mmc_host structure

This field and corresponding defines are simply never used anywhere
in the code.  But its mere presence is enough to confuse some host 
driver authors who attempt to rely on it.  Let's eliminate the 
possibility for confusion and remove it entirely.

Signed-off-by: Nicolas Pitre <nico@....org>
---

yes, it's the second host driver I'm reviewing with this issue...

diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h
index 125eee1..7ab962f 100644
--- a/include/linux/mmc/host.h
+++ b/include/linux/mmc/host.h
@@ -118,10 +118,6 @@ struct mmc_host {
 	unsigned int		removed:1;	/* host is being removed */
 #endif
 
-	unsigned int		mode;		/* current card mode of host */
-#define MMC_MODE_MMC		0
-#define MMC_MODE_SD		1
-
 	struct mmc_card		*card;		/* device attached to this host */
 
 	wait_queue_head_t	wq;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/