linux-kernel - Re: [PATCH] mmc: remove unused 'mode' from the mmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071209180121.22b5948b@poseidon.drzeus.cx>
Date:	Sun, 9 Dec 2007 18:01:21 +0100
From:	Pierre Ossman <drzeus@...eus.cx>
To:	Nicolas Pitre <nico@....org>
Cc:	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: remove unused 'mode' from the mmc_host structure

On Thu, 06 Dec 2007 23:12:46 -0500 (EST)
Nicolas Pitre <nico@....org> wrote:

> This field and corresponding defines are simply never used anywhere
> in the code.  But its mere presence is enough to confuse some host 
> driver authors who attempt to rely on it.  Let's eliminate the 
> possibility for confusion and remove it entirely.
> 
> Signed-off-by: Nicolas Pitre <nico@....org>
> ---

Oopsie. Some old stuff since before the restructuring.

> 
> yes, it's the second host driver I'm reviewing with this issue...
> 

Seems to be a bit of Windows mentality that spills over. Maybe you should give them a quick tutorial in that in Linux we fix stuff at the source. ;)

Thanks for the patch. I've queued it up.

Rgds
Pierre

Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)