linux-kernel - Re: Please revert: PCI: fix IDE legacy mode resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1197231068.6563.12.camel@pasglop>
Date:	Mon, 10 Dec 2007 07:11:08 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Yoichi Yuasa <yoichi_yuasa@...peaks.co.jp>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Greg KH <gregkh@...e.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: Please revert: PCI: fix IDE legacy mode resources


On Sun, 2007-12-09 at 13:39 +0000, Alan Cox wrote:
> > > In fact, I see a deeper problem with Bart's original patch that moved
> > > the "fixup" the PCI probe.
> > 
> > I don't remember changing anything there, could you remind me what it was
> > exactly (commit number or patch name)?
> 
> I'm pretty sure he means the code I added a while ago to actually correct
> our IDE/ATA handling for legacy devices, fix the resource tree being
> wrong and remove tons of special cases from drivers.

Yup, that one, sorry Bart, I thought it was from you.

So far, a quirk grep shows such quirks only in powerpc code though, in
the chrp and powermac platforms (mostly the same one copied over). I'll
do a fix that re-allocate all resources on these instead (though I
suppose another option would be to just write the legacy addresses to
the BARs after turning it into native mode... probably even better).

Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/