linux-kernel - Re: [PATCH 5/4] x86: fix up asm-x86/pgtable*.h formatting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <475EC01D.5090800@goop.org>
Date:	Tue, 11 Dec 2007 08:51:41 -0800
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Christoph Hellwig <hch@...radead.org>
CC:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Glauber de Oliveira Costa <glommer@...il.com>
Subject: Re: [PATCH 5/4] x86: fix up asm-x86/pgtable*.h formatting

Christoph Hellwig wrote:
> On Mon, Dec 10, 2007 at 12:55:33PM -0800, Jeremy Fitzhardinge wrote:
>   
>> +#define set_pte_atomic(pteptr, pteval)		set_pte(pteptr,pteval)
>> +#define set_pte_present(mm,addr,ptep,pteval)	set_pte_at(mm,addr,ptep,pteval)
>>  
>> +#define pte_clear(mm,addr,xp)				\
>> +	do {						\
>> +		set_pte_at(mm, addr, xp, __pte(0));	\
>> +	} while (0)
>> +
>>  #undef pmd_clear
>> +#define pmd_clear(xp)				\
>> +	do {					\
>> +		set_pmd(xp, __pmd(0));		\
>> +	} while (0)
>>     
>
> What about turning these into inline functions to get better type
> checking?
>   

I'll give it a go.  Some of these need to be macros because of #include
hell; I'm not sure if that applies to these ones.

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/