[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20071211141040.a1c6f316.akpm@linux-foundation.org>
Date: Tue, 11 Dec 2007 14:10:40 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: "Kok, Auke" <auke-jan.h.kok@...el.com>
Cc: mbligh@...gle.com, linux-kernel@...r.kernel.org, apw@...dowen.org,
netdev@...r.kernel.org, tglx@...utronix.de, mingo@...e.hu
Subject: Re: 2.6.24-rc4-mm1
On Tue, 11 Dec 2007 13:26:58 -0800
"Kok, Auke" <auke-jan.h.kok@...el.com> wrote:
> Andrew Morton wrote:
> > On Tue, 11 Dec 2007 08:13:52 -0800 "Martin Bligh" <mbligh@...gle.com> wrote:
> >
> >>>
> >>> - Lots of device IDs have been removed from the e1000 driver and moved
> >>> over
> >>> to e1000e. So if your e1000 stops working, you forgot to set
> >>> CONFIG_E1000E.
> >>>
> >>>
> >> Wouldn't it make sense to just default this to on if E1000 was on, rather
> >> than screwing
> >> everybody for no good reason (plus breaking all the automated testing, etc
> >> etc)?
> >> Much though I love random refactoring, it is fairly painful to just keep
> >> changing the
> >> names of things.
> >
> > (cc netdev and Auke)
> >
> > Yes, that would be very sensible. CONFIG_E1000E should default to whatever
> > CONFIG_E1000 was set to.
>
> which is "y" for x86 and friends, ppc, arm and ia64 through 'defconfig'. the
> Kconfig files do not have defaults in them.
I wouldn't be looking at defconfig files - I don't think many people use
them. Most people use their previous config, via oldconfig.
So what we want here is to give them E1000E if they had previously been
using E1000. I don't know how one would do this in Kconfig.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists