linux-kernel - [2.6 patch] fs/nfs/direct.c: remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071211222111.GF14204@stusta.de>
Date:	Tue, 11 Dec 2007 23:21:11 +0100
From:	Adrian Bunk <bunk@...nel.org>
To:	Chuck Lever <chuck.lever@...cle.com>,
	Trond Myklebust <Trond.Myklebust@...app.com>
Cc:	linux-kernel@...r.kernel.org
Subject: [2.6 patch] fs/nfs/direct.c: remove dead code

This code became dead after commit b9148c6b80d802dbc2a7530b29915a80432e50c7
(which BTW doesn't seem to have changed any behaviour) and can therefore 
be removed.

Spotted by the Coverity checker.

Signed-off-by: Adrian Bunk <bunk@...nel.org>

---
--- linux-2.6/fs/nfs/direct.c.old	2007-12-02 21:54:53.000000000 +0100
+++ linux-2.6/fs/nfs/direct.c	2007-12-02 21:55:10.000000000 +0100
@@ -897,15 +897,12 @@ ssize_t nfs_file_direct_write(struct kio
 	if (!count)
 		goto out;	/* return 0 */
 
 	retval = -EINVAL;
 	if ((ssize_t) count < 0)
 		goto out;
-	retval = 0;
-	if (!count)
-		goto out;
 
 	retval = nfs_sync_mapping(mapping);
 	if (retval)
 		goto out;
 
 	retval = nfs_direct_write(iocb, iov, nr_segs, pos, count);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/