| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 12 Dec 2007 10:57:30 -0500 From: Chuck Lever <chuck.lever@...cle.com> To: Adrian Bunk <bunk@...nel.org> Cc: Trond Myklebust <Trond.Myklebust@...app.com>, linux-kernel@...r.kernel.org Subject: Re: [2.6 patch] fs/nfs/direct.c: remove dead code commit b9148c6b should be reverted. It was recently forward-ported from some years-old patches, and is clearly not needed now. On Dec 11, 2007, at 5:21 PM, Adrian Bunk wrote: > This code became dead after commit > b9148c6b80d802dbc2a7530b29915a80432e50c7 > (which BTW doesn't seem to have changed any behaviour) and can > therefore > be removed. > > Spotted by the Coverity checker. > > Signed-off-by: Adrian Bunk <bunk@...nel.org> > > --- > --- linux-2.6/fs/nfs/direct.c.old 2007-12-02 21:54:53.000000000 +0100 > +++ linux-2.6/fs/nfs/direct.c 2007-12-02 21:55:10.000000000 +0100 > @@ -897,15 +897,12 @@ ssize_t nfs_file_direct_write(struct kio > if (!count) > goto out; /* return 0 */ > > retval = -EINVAL; > if ((ssize_t) count < 0) > goto out; > - retval = 0; > - if (!count) > - goto out; > > retval = nfs_sync_mapping(mapping); > if (retval) > goto out; > > retval = nfs_direct_write(iocb, iov, nr_segs, pos, count); > -- Chuck Lever chuck[dot]lever[at]oracle[dot]com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists