[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 11 Dec 2007 21:39:39 -0800
From: Stephen Hemminger <shemminger@...ux-foundation.org>
To: "Joonwoo Park" <joonwpark81@...il.com>
Cc: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<jgarzik@...ox.com>, <baum@...utinetworks.net>,
<andy@...yhouse.net>
Subject: Re: [PATCH 6/7] [NETDEV]: tehuti Fix possible causing oops of
net_rx_action
On Wed, 12 Dec 2007 13:01:27 +0900
"Joonwoo Park" <joonwpark81@...il.com> wrote:
> [NETDEV]: tehuti Fix possible causing oops of net_rx_action
>
> Signed-off-by: Joonwoo Park <joonwpark81@...il.com>
> ---
> drivers/net/tehuti.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/tehuti.c b/drivers/net/tehuti.c
> index 21230c9..955e749 100644
> --- a/drivers/net/tehuti.c
> +++ b/drivers/net/tehuti.c
> @@ -305,6 +305,8 @@ static int bdx_poll(struct napi_struct *napi, int budget)
>
> netif_rx_complete(dev, napi);
> bdx_enable_interrupts(priv);
> + if (unlikely(work_done == napi->weight))
> + return work_done - 1;
> }
> return work_done;
> }
A better fix would be not going over budget in the first place.
--
Stephen Hemminger <shemminger@...ux-foundation.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists