linux-kernel - Re: [PATCH] Revert lazy irq disable for simple irqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.58.0712130756060.27141@gandalf.stny.rr.com>
Date:	Thu, 13 Dec 2007 08:00:38 -0500 (EST)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Ingo Molnar <mingo@...e.hu>
cc:	LKML <linux-kernel@...r.kernel.org>,
	Russell King <rmk+lkml@....linux.org.uk>,
	Thomas Gleixner <tglx@...utronix.de>,
	Remy Bohmer <linux@...mer.net>,
	Daniel Walker <dwalker@...sta.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] Revert lazy irq disable for simple irqs


On Thu, 13 Dec 2007, Ingo Molnar wrote:

>
> * Steven Rostedt <rostedt@...dmis.org> wrote:
>
> > [This patch *is* for mainline Linux]
> >
> > In commit 76d2160147f43f982dfe881404cfde9fd0a9da21 lazy irq disabling
> > was implemented, and the simple irq handler had a masking set to it.

>
> thanks, applied. This is for v2.6.24 too, right?
>

Probably should be. The patch only reverts the change for
handle_simple_irq that shouldn't have been done in the first place. At
worse, this patch just takes us back to what handle_simple_irq use to do,
and at best, it prevents bugs where we somehow fall into the "mask" path
of handle_simple_irq and never unmask. But to hit that path, the driver
probably shouldn't be using handle_simple_irq ;-)

Thanks,

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/