linux-kernel - Re: 2.6.22.14 oops msg with commvault galaxy ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071213130231.GB16905@linux.vnet.ibm.com>
Date:	Thu, 13 Dec 2007 18:32:31 +0530
From:	Dhaval Giani <dhaval@...ux.vnet.ibm.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	"Fortier,Vincent [Montreal]" <Vincent.Fortier1@...GC.CA>,
	Greg KH <gregkh@...e.de>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Srivatsa Vaddagiri <vatsa@...ux.vnet.ibm.com>,
	kay.sievers@...y.org, Balbir Singh <balbir@...ibm.com>,
	maneesh@...ibm.com
Subject: Re: 2.6.22.14 oops msg with commvault galaxy ?

On Thu, Dec 13, 2007 at 01:55:09PM +0100, Ingo Molnar wrote:
> 
> * Dhaval Giani <dhaval@...ux.vnet.ibm.com> wrote:
> 
> > Could you please see if the following patch removes the oops due to 
> > CFS sysfs files? (There might still be the other oops due to the 
> > floppy sysfs files)
> > 
> > Ingo, could you please add this patch in your CFS backport to 2.6.22 
> > and older kernels?
> 
> sure - i've updated the backport patches with this fix.
> 

Thanks!

> >  static void user_attr_init(struct subsys_attribute *sa, char *name, int mode)
> >  {
> > +	sa->attr.owner = NULL;
> >  	sa->attr.name = name;
> 
> i'm wondering why doesnt this affect 2.6.23 and later? Does sysfs 
> initialize the owner field to NULL automatically?
> 

Going through git log, it seems that commit
7b595756ec1f49e0049a9e01a1298d53a7faaa15 deemed attribute->owner as
unnecessary. I guess that answers the question.

-- 
regards,
Dhaval
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/