linux-kernel - Re: 2.6.22.14 oops msg with commvault galaxy ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 13 Dec 2007 22:50:57 +0530
From:	Dhaval Giani <dhaval@...ux.vnet.ibm.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Kay Sievers <kay.sievers@...y.org>, vincent.fortier1@...gc.ca,
	Greg KH <gregkh@...e.de>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Srivatsa Vaddagiri <vatsa@...ux.vnet.ibm.com>,
	Balbir Singh <balbir@...ibm.com>, maneesh@...ibm.com
Subject: Re: 2.6.22.14 oops msg with commvault galaxy ?

On Thu, Dec 13, 2007 at 05:50:59PM +0100, Ingo Molnar wrote:
> 
> * Kay Sievers <kay.sievers@...y.org> wrote:
> 
> > > > > > +   sa->attr.owner = NULL;
> > > > > >     sa->attr.name = name;
> > > > >
> > > > > i'm wondering why doesnt this affect 2.6.23 and later? Does sysfs
> > > > > initialize the owner field to NULL automatically?
> > > > 
> > > > Attibutes do not have an owner anymore:
> > > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=7b595756ec1f49e0049a9e01a1298d53a7faaa15
> > > 
> > > This one also fails to apply properly at the exact same place has 
> > > Ingo's previously posted patch.  Would need to backport his one.
> > 
> > It depends on a completely reworked sysfs logic, I don't think it 
> > makes any sense to backport that.
> 
> well, if it fixes a live bug in a still supported stable kernel 
> release...
> 
> Vincent, could you try to just get rid of all actual uses of 
> se->attr.owner, within fs/sysfs/*.c? Something like the patch below. 
> (totally untested - might be fatally broken as well)
> 

hmm. I am not too sure if it is a good idea. I think it will break a lot
of drivers. But I will just wait for the sysfs experts to speak up thre.

-- 
regards,
Dhaval
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/