linux-kernel - [PATCH -mm] kobject_add error handling when set name failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071214092405.GA3361@darkstar.te-china.tietoenator.com>
Date:	Fri, 14 Dec 2007 17:24:05 +0800
From:	Dave Young <hidave.darkstar@...il.com>
To:	gregkh@...e.de
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: [PATCH -mm] kobject_add error handling when set name failed

In kobject_add, when kobject_set_name failed we should put the kobj and return.

Signed-off-by: Dave Young <hidave.darkstar@...il.com> 

---
lib/kobject.c |   11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)

diff -upr linux/lib/kobject.c linux.new/lib/kobject.c
--- linux/lib/kobject.c	2007-12-14 17:14:03.000000000 +0800
+++ linux.new/lib/kobject.c	2007-12-14 17:17:48.000000000 +0800
@@ -228,8 +228,13 @@ int kobject_add(struct kobject * kobj)
 
 	if (!(kobj = kobject_get(kobj)))
 		return -ENOENT;
-	if (!kobj->k_name)
-		kobject_set_name(kobj, "NO_NAME");
+	if (!kobj->k_name) {
+		error = kobject_set_name(kobj, "NO_NAME"));
+		if (error) {
+			kobject_put(kobj);
+			return error;
+		}
+	}
 	if (!*kobj->k_name) {
 		pr_debug("kobject (%p) attempted to be registered with no "
 			 "name!\n", kobj);
@@ -371,7 +376,7 @@ void kobject_init_ng(struct kobject *kob
 		goto error;
 	}
 	if (!ktype) {
-		err_str = "must have a ktype to be initialized properly!\n";
+		err_str = "must have a ktype to be initialized properly!";
 		goto error;
 	}
 	if (atomic_read(&kobj->kref.refcount)) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/