linux-kernel - Re: [Linux-fbdev-devel] [PATCH] logo: move declarations of logos to linux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0712142148390.4881@anakin>
Date:	Fri, 14 Dec 2007 21:49:03 +0100 (CET)
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	linux-fbdev-devel@...ts.sourceforge.net
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Sam Ravnborg <sam@...nborg.org>, linux-kernel@...r.kernel.org,
	Antonino Daplas <adaplas@...il.com>
Subject: Re: [Linux-fbdev-devel] [PATCH] logo: move declarations of logos to
 linux_logo.h

On Thu, 13 Dec 2007, Marcin Slusarz wrote:
> On Thu, Dec 13, 2007 at 02:31:11AM -0800, Andrew Morton wrote:
> > On Sun, 9 Dec 2007 22:40:31 +0100 Marcin Ślusarz <marcin.slusarz@...il.com> wrote:
> >
> > > logo: move declarations of logos to linux_logo.h
> > >
> > > there was a mismatch between externs in logo.c and code generated by pnmtologo
> > > (on old tree, you need to rm drivers/video/logo/logo_*.c before compilation)
> >
> > This patch (after I fixed it) keeps on causing trouble: mismatches between
> > the header file declarations and the actual definitions of the lookup
> > tables.  This happens as I apply and unapply the patch.
> >
> > It _shouldn't_ happen, but there would appear to be some missing makefile
> > rules.  I guess the C files aren't being regenerated when
> > scripts/pnmtologo.c has been altered, so the C files aren't matching the
> > header which this patch alters.
> 
> Ok, updated patch below:
> 
> logo: move declarations of logos to linux_logo.h
> 
> there was a mismatch between externs in logo.c and code generated by pnmtologo

This may cause section conflicts, cfr.
http://lkml.org/lkml/2007/10/24/65

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds