linux-kernel - Re: [Linux-fbdev-devel] [PATCH] logo: move declarations of logos to linux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071214220005.GA22937@uranus.ravnborg.org>
Date:	Fri, 14 Dec 2007 23:00:05 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	linux-fbdev-devel@...ts.sourceforge.net,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Antonino Daplas <adaplas@...il.com>
Subject: Re: [Linux-fbdev-devel] [PATCH] logo: move declarations of logos to linux_logo.h

On Fri, Dec 14, 2007 at 09:49:03PM +0100, Geert Uytterhoeven wrote:
> On Thu, 13 Dec 2007, Marcin Slusarz wrote:
> > On Thu, Dec 13, 2007 at 02:31:11AM -0800, Andrew Morton wrote:
> > > On Sun, 9 Dec 2007 22:40:31 +0100 Marcin Ślusarz <marcin.slusarz@...il.com> wrote:
> > >
> > > > logo: move declarations of logos to linux_logo.h
> > > >
> > > > there was a mismatch between externs in logo.c and code generated by pnmtologo
> > > > (on old tree, you need to rm drivers/video/logo/logo_*.c before compilation)
> > >
> > > This patch (after I fixed it) keeps on causing trouble: mismatches between
> > > the header file declarations and the actual definitions of the lookup
> > > tables.  This happens as I apply and unapply the patch.
> > >
> > > It _shouldn't_ happen, but there would appear to be some missing makefile
> > > rules.  I guess the C files aren't being regenerated when
> > > scripts/pnmtologo.c has been altered, so the C files aren't matching the
> > > header which this patch alters.
> > 
> > Ok, updated patch below:
> > 
> > logo: move declarations of logos to linux_logo.h
> > 
> > there was a mismatch between externs in logo.c and code generated by pnmtologo
> 
> This may cause section conflicts, cfr.
> http://lkml.org/lkml/2007/10/24/65

If I recall correct then if the first __initdata variable is const then
all date declared __initdata are attempted put in the const section.
So maybe a bit reordering could help it?

But that would serve a fat explanation why...

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/