linux-kernel - Re: [PATCH 7/21] [PATCH] unify common parts of processor.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071218114504.GA22832@elte.hu>
Date:	Tue, 18 Dec 2007 12:45:04 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Glauber de Oliveira Costa <gcosta@...hat.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	glommer@...il.com, tglx@...utronix.de, ehabkost@...hat.com,
	jeremy@...p.org, avi@...ranet.com, anthony@...emonkey.ws,
	virtualization@...ts.linux-foundation.org, rusty@...tcorp.com.au,
	ak@...e.de, chrisw@...s-sol.org, rostedt@...dmis.org,
	hpa@...or.com, zach@...are.com, roland@...hat.com
Subject: Re: [PATCH 7/21] [PATCH] unify common parts of processor.h


* Glauber de Oliveira Costa <gcosta@...hat.com> wrote:

> This patch moves the pieces of processor_32.h and processor_64 that 
> are equal to processor.h. Only what's exactly the same is moved 
> around, the rest not being touched.

argh, it doesnt even build cleanly:

 In file included from include/linux/elf.h:6,
                  from include/linux/module.h:14,
                  from include/linux/crypto.h:21,
                  from arch/x86/kernel/asm-offsets_32.c:7,
                  from arch/x86/kernel/asm-offsets.c:2:
 include/asm/elf.h:286: warning: 'struct mm_struct' declared inside parameter list
 include/asm/elf.h:286: warning: its scope is only this definition or declaration, which is probably not what you want

due to zapping this bit of include/asm-x86/processor_32.h:

 -/* Forward declaration, a strange C thing */
 -struct task_struct;
 -struct mm_struct;

	Ingo

View attachment "config" of type "text/plain" (50046 bytes)