[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4767B70F.1050403@redhat.com>
Date: Tue, 18 Dec 2007 10:03:27 -0200
From: Glauber de Oliveira Costa <gcosta@...hat.com>
To: Rusty Russell <rusty@...tcorp.com.au>
CC: linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
glommer@...il.com, tglx@...utronix.de, mingo@...e.hu,
ehabkost@...hat.com, jeremy@...p.org, avi@...ranet.com,
anthony@...emonkey.ws, virtualization@...ts.linux-foundation.org,
ak@...e.de, chrisw@...s-sol.org, rostedt@...dmis.org,
hpa@...or.com, zach@...are.com, roland@...hat.com
Subject: Re: [PATCH 3/21] [PATCH] move desc_empty to where they belong
Rusty Russell wrote:
> On Tuesday 18 December 2007 09:52:26 Glauber de Oliveira Costa wrote:
>> +static inline int desc_empty(const void *ptr)
>> +{
>> + const u32 *desc = ptr;
>> + return !(desc[0] | desc[1]);
>> +}
>
> Erk. This really needs to be a union, not a void *. I guess we can clean it
> later.
>
> Rusty.
My last series, that unified desc_struct, made it possible to do that.
However, the intent of this, is just move it to a common place.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists