linux-kernel - Re: [PATCH] [RFC] Xilinx SystemACE: Add media hotplug support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa686aa40712192230p206cc716rd85e21cb8d2bdde4@mail.gmail.com>
Date:	Wed, 19 Dec 2007 23:30:16 -0700
From:	"Grant Likely" <grant.likely@...retlab.ca>
To:	axboe@...nel.dk, linux-kernel@...r.kernel.org,
	linuxppc-dev@...abs.org, sr@...x.de, monstr@...str.eu,
	jwilliams@...e.uq.edu.au, stephen.neuendorffer@...inx.com
Subject: Re: [PATCH] [RFC] Xilinx SystemACE: Add media hotplug support

On 12/19/07, Grant Likely <grant.likely@...retlab.ca> wrote:
> From: Grant Likely <grant.likely@...retlab.ca>
>
> Please review and comment.  This patch works in my setup, but I haven't
> tested exhaustively yet.  I also need to fixup the documentation to
> reflect new states before I request this patch to be merged.
>
> Question for the block layer experts:  I'm using add_disk()/del_gendisk()
> functions to inform the kernel of media insertion and removal events.  Is
> this the best way to do this?  I looked at the .media_changed and
> .revalidate_disk hooks, but it doesn't seem like they offer the driver
> any way to notify the kernel of media removal (as opposed to the kernel
> asking the driver)

Heh, actually I *know* I'm doing the wrong thing; but I'm hoping I've
got better chances of getting steered in the right direction if I
start by throwing code out there.  Currently this patch handles
insertion/removal just fine if nothing is mounted, but gets stuck if
the disk is in use.  How do I get the kernel to cancel all pending
requests when deregistering the device?

Thanks,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@...retlab.ca
(403) 399-0195
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/