linux-kernel - Re: [PATCH] [RFC] Xilinx SystemACE: Add media hotplug support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071220144532.GA27885@shadowen.org>
Date:	Thu, 20 Dec 2007 14:45:32 +0000
From:	Andy Whitcroft <apw@...dowen.org>
To:	Grant Likely <grant.likely@...retlab.ca>
Cc:	axboe@...nel.dk, linux-kernel@...r.kernel.org,
	linuxppc-dev@...abs.org, sr@...x.de, monstr@...str.eu,
	jwilliams@...e.uq.edu.au, stephen.neuendorffer@...inx.com
Subject: Re: [PATCH] [RFC] Xilinx SystemACE: Add media hotplug support

On Wed, Dec 19, 2007 at 11:23:48PM -0700, Grant Likely wrote:

> +		/* Make the sysace device 'live' */
> +		if (ace->fsm_state != ACE_FSM_STATE_INVALIDATE_MEDIA);
> +			add_disk(ace->gd);

checkpatch.pl reports the above if as suspect due to the trailing ;.
Looks wrong to me too.

WARNING: Trailing semicolon indicates no statements, indent implies
otherwise
#296: FILE: drivers/block/xsysace.c:835:
+               if (ace->fsm_state != ACE_FSM_STATE_INVALIDATE_MEDIA);
+                       add_disk(ace->gd);

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/