linux-kernel - Re: [PATCH] [RFC] Xilinx SystemACE: Add media hotplug support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fa686aa40712200742i89a2ca9p60365b06adc426c@mail.gmail.com>
Date:	Thu, 20 Dec 2007 08:42:41 -0700
From:	"Grant Likely" <grant.likely@...retlab.ca>
To:	"Andy Whitcroft" <apw@...dowen.org>
Cc:	axboe@...nel.dk, linux-kernel@...r.kernel.org,
	linuxppc-dev@...abs.org, sr@...x.de, monstr@...str.eu,
	jwilliams@...e.uq.edu.au, stephen.neuendorffer@...inx.com
Subject: Re: [PATCH] [RFC] Xilinx SystemACE: Add media hotplug support

On 12/20/07, Andy Whitcroft <apw@...dowen.org> wrote:
> On Wed, Dec 19, 2007 at 11:23:48PM -0700, Grant Likely wrote:
>
> > +             /* Make the sysace device 'live' */
> > +             if (ace->fsm_state != ACE_FSM_STATE_INVALIDATE_MEDIA);
> > +                     add_disk(ace->gd);
>
> checkpatch.pl reports the above if as suspect due to the trailing ;.
> Looks wrong to me too.

Ah, good catch.

Thanks.
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@...retlab.ca
(403) 399-0195
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/