linux-kernel - Re: Update ip command line processing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071220.152121.188610437.davem@davemloft.net>
Date:	Thu, 20 Dec 2007 15:21:21 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	horms@...ge.net.au
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	apw@...ibm.com
Subject: Re: Update ip command line processing

From: Simon Horman <horms@...ge.net.au>
Date: Tue, 18 Dec 2007 17:57:32 +0900

> @@ -1414,9 +1414,16 @@ late_initcall(ip_auto_config);
>   */
>  static int __init ic_proto_name(char *name)
>  {
> +	if (!name) {
> +		return 1;
> +	}

I do not see any circumstance under which this pointer can
be NULL.  Judging by your other changes, I think you mean
to use "!*name" here.

Maybe:

	if (*name == '\0')

would make it clearer what you're checking for, an
empty string.

Otherwise I'm fine with your change.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/