linux-kernel - Re: [PATCH 2/2] scsi: Use new __dma_buffer to align sense buffer in scsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071221103326.7ce1bc4f@the-village.bc.nu>
Date:	Fri, 21 Dec 2007 10:33:26 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	<linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>, <rdreier@...co.com>,
	<linux-scsi@...r.kernel.org>, <rmk@....linux.org.uk>,
	<davem@...emloft.net>, <james.bottomley@...eleye.com>,
	<ralf@...ux-mips.org>
Subject: Re: [PATCH 2/2] scsi: Use new __dma_buffer to align sense buffer in
 scsi_cmnd

On Fri, 21 Dec 2007 13:30:08 +1100
Benjamin Herrenschmidt <benh@...nel.crashing.org> wrote:

> The sense buffer ins scsi_cmnd can nowadays be DMA'ed into directly
> by some low level drivers (that typically happens with USB mass
> storage).

Should that not be fixed in USB storage by using pci_alloc_coherent on the
PCI device of the hub not peeing directly into kernel space ?

It's also incomplete as a fix because I don't see what guarantees the
buffer size will always exceed cache line size

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/