linux-kernel - Re: Linux 2.6.24-rc5 x86 architecture no longer Oopses...

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071221024211.f4207136.akpm@linux-foundation.org>
Date:	Fri, 21 Dec 2007 02:42:11 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	trond.myklebust@....uio.no, tglx@...utronix.de, mingo@...hat.com,
	hpa@...or.com, linux-kernel@...r.kernel.org
Subject: Re: Linux 2.6.24-rc5 x86 architecture no longer Oopses...

On Fri, 21 Dec 2007 11:27:27 +0100 Ingo Molnar <mingo@...e.hu> wrote:

> > local_read_flags().
> > 
> > > that should have been raw_local_irq_save(flags)!
> > 
> > So raw_local_save_flags() and raw_local_irq_save() have different semantics.
> > 
> > omigawd, what have we done?
> 
> i really tried to get this fixed years ago - but did not think of 
> local_read_flags as a solution. The patch below fixes this.
> 
> (if it's too burdensome to carry right now then i can regenerate this 
> patch in 30 seconds in the 2.6.25 merge window - but please remind me 
> then. Perhaps put in a patch into your queue that adds a comment to 
> remind me :-) )

I'd suggest that we add a local_read_flags() along with local_save_flags().
Then I can merge the parts of the patch which don't get destroyed by ongoing
churn and then we can come in and clean up the stragglers later.

box:/usr/src/25> grep -l local_save_flags patches/*.patch 
patches/git-perfmon.patch
patches/git-sh.patch
patches/git-x86.patch
patches/i386-use-raw_smp_processor_id-in-die.patch
patches/mn10300-add-the-mn10300-am33-architecture-to-the-kernel.patch
patches/origin.patch


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/