linux-kernel - Re: 2.6.24-rc5-mm1: problems with cat /proc/kpageflags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071220.191505.122863242.davem@davemloft.net>
Date:	Thu, 20 Dec 2007 19:15:05 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	mpm@...enic.com
Cc:	m.kozlowski@...land.pl, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, sparclinux@...r.kernel.org
Subject: Re: 2.6.24-rc5-mm1: problems with cat /proc/kpageflags

From: Matt Mackall <mpm@...enic.com>
Date: Thu, 20 Dec 2007 19:06:55 -0600

> @@ -707,7 +707,10 @@ static ssize_t kpagecount_read(struct fi
>  		return -EIO;
>  
>  	while (count > 0) {
> -		ppage = pfn_to_page(pfn++);
> +		ppage = 0;
> +		if (pfn_valid(pfn))
> +			ppage = pfn_to_page(pfn);
> +		pfn++;
>  		if (!ppage)
>  			pcount = 0;
>  		else

Yes that should work, please use "NULL" in the final
version of the patch instead of "0" so that sparse is
happy.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/