linux-kernel - Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 22 Dec 2007 10:06:38 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Arjan van de Ven <arjan@...radead.org>
cc:	Jeff Garzik <jeff@...zik.org>, linux-kernel@...r.kernel.org,
	gregkh@...e.de, linux-pci@...ey.karlin.mff.cuni.cz
Subject: Re: [patch] Make MMCONFIG space (extended PCI config space) a driver
 opt-in issue

On Sat, 22 Dec 2007, Arjan van de Ven wrote:

> On Sat, 22 Dec 2007 09:20:06 -0500
> Jeff Garzik <jeff@...zik.org> wrote:
> > 
> > Yuck.  And, Linus is just being silly.  Wait a year then turn on 
> > MMCONFIG :)  It took PCI MSI a while to mature, but is finally
> > getting there.

That _really_ doesn't work.

Old machines don't go away. We can't just say "wait a year and turn on 
MMCONFIG", because all the broken machines WILL STILL EXIST.

> Do you hate the name or the concept? I'm certainly open for a better name.... 

Just make it so. The name is fine, the concept is unavoidable. The people 
who complain are whiners that haven't ever had to deal with the fact that 
there are broken machines around. 

For example, right now Jeff never sees the problem, because when MMCONFIG 
doesn't work, it's never his problem - nothing in the machine works. But 
if he has to add a "pci_enable_mmconfig()" to the drivers he maintains, he 
sees it as a _new_ problem, so he obviously thinks it's stupid: he was 
never impacted by the issues it fixed!

So it's natural for Jeff to not like it, but that doesn't make Jeff right 
in this case. It just means that Jeff never had to worry about it before, 
because as long as MMCONFIG wasn't per-driver, the problems it caused were 
never *his* problems. But that doesn't make them less of a problem.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/