linux-kernel - Re: [PATCH 05/16] make write() operation smp aware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200712261040.24771.rusty@rustcorp.com.au>
Date:	Wed, 26 Dec 2007 10:40:24 +1100
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Glauber de Oliveira Costa <gcosta@...hat.com>
Cc:	lguest@...abs.org, glommer@...il.com, linux-kernel@...r.kernel.org,
	virtualization@...ts.linux-foundation.org, rostedt@...dmis.org
Subject: Re: [PATCH 05/16] make write() operation smp aware

On Friday 21 December 2007 00:33:45 Glauber de Oliveira Costa wrote:
> --- a/drivers/lguest/lguest_user.c
> +++ b/drivers/lguest/lguest_user.c
> @@ -223,14 +223,21 @@ static ssize_t write(struct file *file, const char
...
>  	/* If you haven't initialized, you must do that first. */
> -	if (req != LHREQ_INITIALIZE && !lg)
> -		return -EINVAL;
> +	if (req != LHREQ_INITIALIZE) {
> +		if (!lg)
> +			return -EINVAL;
> +		vcpu = &lg->vcpus[vcpu_id];
> +		if (!vcpu)
> +			return -EINVAL;
> +	}

Bounds check again...

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/