linux-kernel - Re: asm-x86/msr.h for sanitized headers: clean it or punt it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <p73sl1jyrqx.fsf@bingen.suse.de>
Date:	Mon, 31 Dec 2007 13:26:46 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Mike Frysinger <vapier@...too.org>
Cc:	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: asm-x86/msr.h for sanitized headers: clean it or punt it

Mike Frysinger <vapier@...too.org> writes:

> The current asm-x86/msr.h does not actually define anything for (!__KERNEL__
> && __i386__).  For x86_64, it fails to build due to u32/u64 types being used.
> Simply not installing the header seems easiest to me.  Otherwise, x86_64 will
> need sanitizing and i386 should have things added back, otherwise it's just a
> pointless empty header.

Please don't -- asm/msr.h is very useful in user space for rdtscll et.al.
I use it all the time in test programs.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/