linux-kernel - Re: asm-x86/msr.h for sanitized headers: clean it or punt it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200712311033.34489.vapier@gentoo.org>
Date:	Mon, 31 Dec 2007 10:33:33 -0500
From:	Mike Frysinger <vapier@...too.org>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: asm-x86/msr.h for sanitized headers: clean it or punt it

On Monday 31 December 2007, Andi Kleen wrote:
> Mike Frysinger <vapier@...too.org> writes:
> > The current asm-x86/msr.h does not actually define anything for
> > (!__KERNEL__ && __i386__).  For x86_64, it fails to build due to u32/u64
> > types being used. Simply not installing the header seems easiest to me. 
> > Otherwise, x86_64 will need sanitizing and i386 should have things added
> > back, otherwise it's just a pointless empty header.
>
> Please don't -- asm/msr.h is very useful in user space for rdtscll et.al.
> I use it all the time in test programs.

can you enumerate which functions need to actually go to userspace then ?  the 
__KERNEL__ markings are a crapshoot at the moment.  you must also be jumping 
through hoops in order to use the header in the first place since the vanilla 
one wont compile out of the box.
-mike

Download attachment "signature.asc " of type "application/pgp-signature" (836 bytes)