linux-kernel - Re: [PATCHv3] powerpc: DBox2 Board Support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <477CCB0F.8020504@scram.de>
Date:	Thu, 03 Jan 2008 12:46:23 +0100
From:	Jochen Friedrich <jochen@...am.de>
To:	Jochen Friedrich <jochen@...am.de>, linuxppc-dev@...abs.org,
	Scott Wood <scottwood@...escale.com>,
	linux-kernel@...r.kernel.org,
	"linuxppc-embedded@...abs.org" <linuxppc-embedded@...abs.org>
Subject: Re: [PATCHv3] powerpc: DBox2 Board Support

Hi David,

>> +/ {
>> +	model = "unknown,dbox2"; // boot wrapper fills in correct manufacturer
> 
> Probably better just to leave model out of the dts and let the
> bootwrapper add it.

Unfortunately, dtc requires a model:

$ dtc arch/powerpc/boot/dts/dbox2.dts
DTC: dts->dts  on file "arch/powerpc/boot/dts/dbox2.dts"
ERROR: Missing "model" property in /

>> +		flash@0,0 {
>> +			compatible = "cfi-flash";
>> +			reg = <0 0 800000>;
>> +			bank-width = <4>;
>> +			device-width = <1>;
>> +			#address-cells = <1>;
>> +			#size-cells = <1>;
>> +			partition@0 {
>> +				label = "BR bootloader";
>> +				reg = <0 20000>;
>> +				read-only;
>> +			};
>> +			partition@...00 {
>> +				label = "FLFS (U-Boot)";
>> +				reg = <20000 20000>;
>> +			};
>> +			partition@...00 {
>> +				label = "rootfs";
>> +				reg = <40000 7c0000>;
>> +			};
>> +			ovpartition@...00 {
> 
> Uh.. I really don't know what the MTD driver will handle these
> overlapping partitions.  I suspect it will not be pretty...
> 
>> +				label = "Flash without bootloader";
>> +				reg = <20000 7e0000>;
>> +			};
>> +			ovpartition@0 {
>> +				label = "Complete Flash";
>> +				reg = <0 800000>;
>> +				read-only;
>> +			};
>> +		};
>> +	};

MTD handles this correctly. dbox2 uses "Flash without bootloader" for flashing image updates and "Complete Flash" for creating a backup of everything.
OpenWRT also uses overlapping partitions BTW (and also for flashing updates).

Thanks,
Jochen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/