linux-kernel - Re: [PATCH x86] [4/16] Add /proc/irq/*/spurious to dump the spurious irq debugging state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200801041322.01190.ak@suse.de>
Date:	Fri, 4 Jan 2008 13:22:01 +0100
From:	Andi Kleen <ak@...e.de>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH x86] [4/16] Add /proc/irq/*/spurious to dump the spurious irq debugging state

ix it:

You mean the new line after local variables?

I never liked this rule. Newlines may make sense on very large functions, but
on short functions they just obscure more. And I actually checked CodingStyle now 
and it says nothing about that. So please apply the patch anyways.

-Andi

> > +static int irq_spurious_read(char *page, char **start, off_t off,
> > +				  int count, int *eof, void *data)
> > +{
> > +	struct irq_desc *d = &irq_desc[(long) data];
> > +	return sprintf(page, "count %u\n"
> > +			     "unhandled %u\n"
> 
> 	Ingo
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/